Fix BasicTrackInfo having wrong TrackID

Add Character Limit to  TrackList Method to fix tracklists being to big for messages

GitVersion.yml

@@ -1,9 +1,33 @@
 mode: ContinuousDelivery
-branches: 
+branches:
-  develop:
-    increment: None
   main:
-    increment: None
+    regex: ^master$|^main$
+    mode: ContinuousDelivery
+    tag: ''
+    increment: Minor
+    prevent-increment-of-merged-branch-version: true
+    track-merge-target: false
+    source-branches: [ 'develop', 'release' ]
+    tracks-release-branches: false
+    is-release-branch: true
+    is-mainline: true
+    pre-release-weight: 55000
+  develop:
+    regex: ^dev(elop)?(ment)?$
+    mode: ContinuousDeployment
+    tag: pre
+    increment: Patch
+    prevent-increment-of-merged-branch-version: false
+    track-merge-target: true
+    source-branches: []
+    tracks-release-branches: true
+    is-release-branch: false
+    is-mainline: false
+    pre-release-weight: 0
 ignore:
   sha: []
 merge-message-formats: {}
+major-version-bump-message: '\+semver:\s?(breaking|major)'
+minor-version-bump-message: '\+semver:\s?(feature|minor)'
+patch-version-bump-message: '\+semver:\s?(fix|patch)'
+commit-message-incrementing: Enabled

TomatenMusic/Models/BasicTrackInfo.cs

@@ -27,7 +27,7 @@ namespace TomatenMusic_Api.Models
 
             Name = track.Title;
             Platform = ctx.SpotifyIdentifier == null ? TrackPlatform.YOUTUBE : TrackPlatform.SPOTIFY;
-            YoutubeId = track.Identifier;
+            YoutubeId = track.TrackIdentifier;
             SpotifyId = ctx.SpotifyIdentifier;
             URL = ctx.YoutubeUri;
         }

TomatenMusic/Program.cs

@@ -4,11 +4,9 @@ using TomatenMusic_Api.Auth.Services;
 
 var builder = WebApplication.CreateBuilder(args);
 
-// Add services to the container.
 
 builder.Services.AddControllers();
 builder.Services.AddCors();
-// Learn more about configuring Swagger/OpenAPI at https://aka.ms/aspnetcore/swashbuckle
 builder.Services.AddEndpointsApiExplorer();
 builder.Services.AddSwaggerGen();
 

TomatenMusic/appsettings.json

@@ -4,8 +4,8 @@
   },
     "Logging": {
       "LogLevel": {
-        "Default": "Information",
+        "Default": "Debug",
-        "Microsoft.AspNetCore": "Information"
+        "Microsoft.AspNetCore": "Debug"
       }
     }
 }

TomatenMusic/config.json

@@ -1,5 +1,5 @@
 {
-  "TOKEN": " ",
+  "TOKEN": "Bot_Token",
   "LavaLinkPassword": " ",
   "SpotifyClientId": " ",
   "SpotifyClientSecret": " ",

TomatenMusicCore/Commands/PlayCommandGroup.cs

@@ -5,6 +5,7 @@ using Lavalink4NET.Player;
 using Microsoft.Extensions.Logging;
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Text;
 using System.Threading.Tasks;
 using TomatenMusic.Commands.Checks;
@@ -35,6 +36,8 @@ namespace TomatenMusic.Commands
             [OnlyGuildCheck]
             public async Task PlayQueryCommand(InteractionContext ctx, [Option("query", "The song search query.")] string query)
             {
+            var sw = Stopwatch.StartNew();
+
                 await ctx.DeferAsync(true);
 
                 GuildPlayer player = (GuildPlayer)_audioService.GetPlayer(ctx.Guild.Id);
@@ -50,7 +53,9 @@ namespace TomatenMusic.Commands
                     await ctx.EditResponseAsync(new DiscordWebhookBuilder()
                      .WithContent($"❌ An error occured while resolving your query: ``{ex.Message}``, ```{ex.StackTrace}```")
                       );
-                    return;
+                sw.Stop();
+                _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                return;
                 }
 
                 try
@@ -66,7 +71,9 @@ namespace TomatenMusic.Commands
                         await ctx.EditResponseAsync(new DiscordWebhookBuilder()
                          .WithContent($"❌ An error occured while connecting to your Channel: ``{ex.Message}``")
                           );
-                        return;
+                    sw.Stop();
+                    _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                    return;
                     }
                 }
 
@@ -74,7 +81,7 @@ namespace TomatenMusic.Commands
                 {
                     if (response.isPlaylist)
                     {
-                        LavalinkPlaylist playlist = response.Playlist;
+                        ILavalinkPlaylist playlist = response.Playlist;
                         await player.PlayPlaylistNowAsync(playlist);
 
                         _ = ctx.EditResponseAsync(new DiscordWebhookBuilder().WithContent("Now Playing:").AddEmbed(
@@ -97,9 +104,13 @@ namespace TomatenMusic.Commands
                     await ctx.EditResponseAsync(new DiscordWebhookBuilder()
                      .WithContent($"❌ An error occured while playing your Query: ``{ex.Message}``")
                       );
-                    return;
+                sw.Stop();
+                _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                return;
                 }
-            }
+            sw.Stop();
+            _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+        }
 
             [SlashCommand("file", "Play a song file. (mp3/mp4)")]
             [UserInVoiceChannelCheck]
@@ -107,8 +118,9 @@ namespace TomatenMusic.Commands
             [OnlyGuildCheck]
             public async Task PlayFileCommand(InteractionContext ctx, [Option("File", "The File that should be played.")] DiscordAttachment file)
             {
+            var sw = Stopwatch.StartNew();
 
-                await ctx.DeferAsync(true);
+            await ctx.DeferAsync(true);
 
                 GuildPlayer player = (GuildPlayer)_audioService.GetPlayer(ctx.Guild.Id);
 
@@ -123,7 +135,9 @@ namespace TomatenMusic.Commands
                     await ctx.EditResponseAsync(new DiscordWebhookBuilder()
                      .WithContent($"❌ An error occured while resolving your file: ``{ex.Message}``")
                       );
-                    return;
+                sw.Stop();
+                _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                return;
                 }
 
                 try
@@ -138,7 +152,9 @@ namespace TomatenMusic.Commands
                         await ctx.EditResponseAsync(new DiscordWebhookBuilder()
                          .WithContent($"❌ An error occured while connecting to your Channel: ``{ex.Message}``")
                           );
-                        return;
+                    sw.Stop();
+                    _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                    return;
                     }
                 }
 
@@ -148,7 +164,9 @@ namespace TomatenMusic.Commands
                     .AddEmbed(Common.AsEmbed(track, player.PlayerQueue.LoopType, 0)));
 
                 await player.PlayNowAsync(response.Track);
-            }
+            sw.Stop();
+            _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+        }
         }
 
         [SlashCommandGroup("play", "Queues or plays the Song")]
@@ -172,7 +190,9 @@ namespace TomatenMusic.Commands
             [OnlyGuildCheck]
             public async Task PlayQueryCommand(InteractionContext ctx, [Option("query", "The song search query.")] string query)
             {
-                await ctx.DeferAsync(true);
+            var sw = Stopwatch.StartNew();
+
+            await ctx.DeferAsync(true);
 
                 GuildPlayer player = (GuildPlayer)_audioService.GetPlayer(ctx.Guild.Id);
 
@@ -187,7 +207,9 @@ namespace TomatenMusic.Commands
                     await ctx.EditResponseAsync(new DiscordWebhookBuilder()
                      .WithContent($"❌ An error occured while resolving your query: ``{ex.Message}``, ```{ex.StackTrace}```")
                       );
-                    return;
+                sw.Stop();
+                _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                return;
                 }
 
                 try
@@ -202,18 +224,20 @@ namespace TomatenMusic.Commands
                         await ctx.EditResponseAsync(new DiscordWebhookBuilder()
                          .WithContent($"❌ An error occured while connecting to your Channel: ``{ex.Message}``")
                           );
-                        return;
+                    sw.Stop();
+                    _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                    return;
                     }
                 }
 
-                try
+            try
                 {
                     if (response.isPlaylist)
                     {
-                        LavalinkPlaylist playlist = response.Playlist;
+                        ILavalinkPlaylist playlist = response.Playlist;
                         await player.PlayPlaylistAsync(playlist);
 
-                        _ = ctx.EditResponseAsync(new DiscordWebhookBuilder().WithContent("Now Playing:").AddEmbed(
+                        await ctx.EditResponseAsync(new DiscordWebhookBuilder().WithContent("Now Playing:").AddEmbed(
                         Common.AsEmbed(playlist)
                         ));
 
@@ -231,11 +255,15 @@ namespace TomatenMusic.Commands
                 catch (Exception ex)
                 {
                     await ctx.EditResponseAsync(new DiscordWebhookBuilder()
-                     .WithContent($"❌ An error occured while playing your Track: ``{ex.Message}``")
+                     .WithContent($"❌ An error occured while playing your Track: ``{ex.Message}``, ```{ex.StackTrace}```")
                       );
-                    return;
+                sw.Stop();
+                _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                return;
                 }
-            }
+            sw.Stop();
+            _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+        }
 
             [SlashCommand("file", "Play a song file. (mp3/mp4)")]
             [UserInVoiceChannelCheck]
@@ -243,8 +271,9 @@ namespace TomatenMusic.Commands
             [OnlyGuildCheck]
             public async Task PlayFileCommand(InteractionContext ctx, [Option("File", "The File that should be played.")] DiscordAttachment file)
             {
+            var sw = Stopwatch.StartNew();
 
-                await ctx.DeferAsync(true);
+            await ctx.DeferAsync(true);
 
                 GuildPlayer player = (GuildPlayer)_audioService.GetPlayer(ctx.Guild.Id);
 
@@ -259,7 +288,9 @@ namespace TomatenMusic.Commands
                     await ctx.EditResponseAsync(new DiscordWebhookBuilder()
                      .WithContent($"❌ An error occured while resolving your file: ``{ex.Message}``")
                       );
-                    return;
+                sw.Stop();
+                _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                return;
                 }
 
                 try
@@ -274,7 +305,9 @@ namespace TomatenMusic.Commands
                         await ctx.EditResponseAsync(new DiscordWebhookBuilder()
                          .WithContent($"❌ An error occured while connecting to your Channel: ``{ex.Message}``")
                           );
-                        return;
+                    sw.Stop();
+                    _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
+                    return;
                     }
                 }
 
@@ -284,6 +317,9 @@ namespace TomatenMusic.Commands
                     .AddEmbed(Common.AsEmbed(track, player.PlayerQueue.LoopType, player.State == PlayerState.NotPlaying ? 0 : player.PlayerQueue.Queue.Count + 1)));
 
                 await player.PlayAsync(response.Track);
+
+            sw.Stop();
+            _logger.LogDebug($"Command {ctx.CommandName} took {sw.ElapsedMilliseconds}ms to execute.");
             }
         }
 }

TomatenMusicCore/Music/Entitites/FullTrackContext.cs

@@ -34,7 +34,7 @@ namespace TomatenMusic.Music.Entitites
         public int SpotifyPopularity { get; set; }
         public Uri SpotifyUri { get; set; }
 
-        public static async Task<LavalinkTrack> PopulateAsync(LavalinkTrack track, string spotifyIdentifier = null)
+        public static async Task<LavalinkTrack> PopulateAsync(LavalinkTrack track, FullTrack spotifyTrack = null, string spotifyId = null)
         {
             FullTrackContext context = (FullTrackContext)track.Context;
 
@@ -43,12 +43,15 @@ namespace TomatenMusic.Music.Entitites
 
             var spotifyService = TomatenMusicBot.ServiceProvider.GetRequiredService<ISpotifyService>();
             var youtubeService = TomatenMusicBot.ServiceProvider.GetRequiredService<YoutubeService>();
-            context.SpotifyIdentifier = spotifyIdentifier;
+            if (spotifyId != null)
-            context.YoutubeUri = new Uri($"https://youtu.be/{track.TrackIdentifier}");
+                context.SpotifyIdentifier = spotifyId;
+            else if (spotifyTrack != null)
+                context.SpotifyIdentifier = spotifyTrack.Id;
+                
+            context.YoutubeUri = new Uri(track.Source);
             track.Context = context;
-            Console.WriteLine(context);
             await youtubeService.PopulateTrackInfoAsync(track);
-            await spotifyService.PopulateTrackAsync(track);
+            await spotifyService.PopulateTrackAsync(track, spotifyTrack);
             
             return track;
         }

TomatenMusicCore/Music/Entitites/ILavalinkPlaylist.cs

@@ -8,7 +8,7 @@ using Lavalink4NET.Player;
 
 namespace TomatenMusic.Music.Entitites
 {
-    public interface LavalinkPlaylist
+    public interface ILavalinkPlaylist
     {
         public string Name { get; }
         public IEnumerable<LavalinkTrack> Tracks { get; }

TomatenMusicCore/Music/Entitites/SpotifyPlaylist.cs

@@ -5,7 +5,7 @@ using System.Text;
 
 namespace TomatenMusic.Music.Entitites
 {
-    public class SpotifyPlaylist : LavalinkPlaylist
+    public class SpotifyPlaylist : ILavalinkPlaylist
     {
         public string Name { get; }
         public IEnumerable<LavalinkTrack> Tracks { get; }

TomatenMusicCore/Music/Entitites/YoutubePlaylist.cs

@@ -4,10 +4,12 @@ using System.Text;
 using System.Linq;
 using Google.Apis.YouTube.v3.Data;
 using Lavalink4NET.Player;
+using Microsoft.Extensions.DependencyInjection;
+using TomatenMusic.Services;
 
 namespace TomatenMusic.Music.Entitites
 {
-    public class YoutubePlaylist : LavalinkPlaylist
+    public class YoutubePlaylist : ILavalinkPlaylist
     {
         public string Name { get; }
 
@@ -28,11 +30,12 @@ namespace TomatenMusic.Music.Entitites
 
         public YoutubePlaylist(string name, IEnumerable<LavalinkTrack> tracks, Uri uri)
         {
-            Identifier = uri.ToString().Replace("https://www.youtube.com/playlist?list=", "");
+            Identifier = uri.ToString().Replace("https://www.youtube.com/playlist?list=", "").Replace("https://youtube.com/playlist?list=", "");
             Name = name;
             Tracks = tracks;
             Url = uri;
             TrackCount = tracks.Count();
+
         }
     }
 }

TomatenMusicCore/Music/GuildPlayer.cs

@@ -114,7 +114,7 @@ namespace TomatenMusic.Music
             QueuePrompt.UpdateFor(GuildId);
         }
 
-        public async Task PlayPlaylistAsync(LavalinkPlaylist playlist)
+        public async Task PlayPlaylistAsync(ILavalinkPlaylist playlist)
         {
             EnsureNotDestroyed();
             EnsureConnected();
@@ -132,9 +132,8 @@ namespace TomatenMusic.Music
             QueuePrompt.UpdateFor(GuildId);
         }
 
-        public async Task PlayPlaylistNowAsync(LavalinkPlaylist playlist)
+        public async Task PlayPlaylistNowAsync(ILavalinkPlaylist playlist)
         {
-
             EnsureConnected();
             EnsureNotDestroyed();
             if (!PlayerQueue.Queue.Any())
@@ -159,8 +158,16 @@ namespace TomatenMusic.Music
 
         public async Task RewindAsync()
         {
-            MusicActionResponse response = PlayerQueue.Rewind();
+            EnsureNotDestroyed();
+            EnsureConnected();
+            if (Position.Position.Seconds < 4)
+            {
+                await ReplayAsync();
+                return;
+            }
 
+            MusicActionResponse response = PlayerQueue.Rewind();
+            
             _logger.LogInformation($"Rewinded Track {CurrentTrack.Title} for Track {response.Track.Title}");
             await base.PlayAsync(response.Track);
             QueuePrompt.UpdateFor(GuildId);
@@ -168,6 +175,8 @@ namespace TomatenMusic.Music
 
         public async Task SkipAsync()
         {
+            EnsureNotDestroyed();
+            EnsureConnected();
             MusicActionResponse response = PlayerQueue.NextTrack(true);
 
             _logger.LogInformation($"Skipped Track {CurrentTrack.Title} for Track {response.Track.Title}");

TomatenMusicCore/Music/MusicActionResponse.cs

@@ -8,11 +8,11 @@ namespace TomatenMusic.Music
 {
     public class MusicActionResponse
     {
-        public LavalinkPlaylist Playlist { get; }
+        public ILavalinkPlaylist Playlist { get; }
         public LavalinkTrack Track { get; }
         public IEnumerable<LavalinkTrack> Tracks { get; }
         public bool isPlaylist { get; }
-        public MusicActionResponse(LavalinkTrack track = null, LavalinkPlaylist playlist = null, IEnumerable<LavalinkTrack> tracks = null)
+        public MusicActionResponse(LavalinkTrack track = null, ILavalinkPlaylist playlist = null, IEnumerable<LavalinkTrack> tracks = null)
         {
             Playlist = playlist;
             Track = track;

TomatenMusicCore/Music/PlayerQueue.cs

@@ -18,7 +18,7 @@ namespace TomatenMusic.Music
         public Queue<LavalinkTrack> Queue { get; set; } = new Queue<LavalinkTrack>();
         public Queue<LavalinkTrack> PlayedTracks { get; set; } = new Queue<LavalinkTrack>();
         public ILogger<PlayerQueue> _logger { get; set; } = TomatenMusicBot.ServiceProvider.GetRequiredService<ILogger<PlayerQueue>>();
-        public LavalinkPlaylist CurrentPlaylist { get; set; }
+        public ILavalinkPlaylist CurrentPlaylist { get; set; }
 
         public LoopType LoopType { get; private set; } = LoopType.NONE;
 
@@ -36,12 +36,14 @@ namespace TomatenMusic.Music
                 QueueLoopList.Add(track);
         }
 
-        public Task QueuePlaylistAsync(LavalinkPlaylist playlist)
+        public Task QueuePlaylistAsync(ILavalinkPlaylist playlist)
         {
             return Task.Run(() =>
             {
-                if (CurrentPlaylist == null)
+                if (CurrentPlaylist == null && Queue.Count == 0)
                     CurrentPlaylist = playlist;
+                else
+                    CurrentPlaylist = null;
 
                 _logger.LogInformation("Queued Playlist {0}", playlist.Name);
                 foreach (LavalinkTrack track in playlist.Tracks)

TomatenMusicCore/Prompt/Implementation/QueuePrompt.cs

@@ -269,7 +269,10 @@ namespace TomatenMusic.Prompt.Implementation
 
         protected async override Task<DiscordMessageBuilder> GetMessageAsync()
         {
-            return new DiscordMessageBuilder().AddEmbed(Common.GetQueueEmbed(Player)).AddEmbed(await Common.CurrentSongEmbedAsync(Player)).AddEmbeds(Embeds);
+            return new DiscordMessageBuilder()
+                .AddEmbed(Common.GetQueueEmbed(Player))
+                .AddEmbed(await Common.CurrentSongEmbedAsync(Player))
+                .AddEmbeds(Embeds);
         }
     }
 }

TomatenMusicCore/Prompt/Implementation/SongListActionPrompt.cs

@@ -32,7 +32,7 @@ namespace TomatenMusic.Prompt.Implementation
             DiscordEmbedBuilder builder = new DiscordEmbedBuilder()
                 .WithTitle("What do you want to do with these Tracks?");
 
-            builder.WithDescription(Common.TrackListString(Tracks));
+            builder.WithDescription(Common.TrackListString(Tracks, 1000));
 
             return Task.FromResult(new DiscordMessageBuilder().WithEmbed(builder.Build()));
         }

TomatenMusicCore/Prompt/Implementation/SongSelectorPrompt.cs

@@ -87,7 +87,7 @@ namespace TomatenMusic.Prompt.Implementation
         {
 
             builder.WithTitle(Title);
-            builder.WithDescription(Common.TrackListString(PageManager.GetPage(CurrentPage)));
+            builder.WithDescription(Common.TrackListString(PageManager.GetPage(CurrentPage), 4000));
             List<DiscordEmbed> embeds = new List<DiscordEmbed>();
             embeds.Add(builder.Build());
 

TomatenMusicCore/Prompt/Model/DiscordPromptBase.cs

@@ -164,6 +164,7 @@ namespace TomatenMusic.Prompt.Model
             _client = client.GetShard((ulong)interaction.GuildId);
 
             _client.ComponentInteractionCreated += Discord_ComponentInteractionCreated;
+
             ActivePrompts.Add(this);
             AddGuids();
             DiscordWebhookBuilder builder = await GetWebhookMessageAsync();

TomatenMusicCore/Prompt/Option/IPromptOption.cs

@@ -19,8 +19,5 @@ namespace TomatenMusic.Prompt.Option
         public Func<IPromptOption, Task<IPromptOption>> UpdateMethod { get; set; }
         public Func<DSharpPlus.EventArgs.ComponentInteractionCreateEventArgs, DiscordClient, IPromptOption, Task> Run { get; set; }
 
-
-
-
     }
 }

TomatenMusicCore/Services/SpotifyService.cs

@@ -11,6 +11,7 @@ using TomatenMusic.Services;
 using TomatenMusic.Music;
 using Lavalink4NET;
 using Lavalink4NET.Player;
+using System.Runtime.Caching;
 
 namespace TomatenMusic.Services
 {
@@ -18,9 +19,9 @@ namespace TomatenMusic.Services
     public interface ISpotifyService
     {
         public Task<MusicActionResponse> ConvertURL(string url);
-        public Task<SpotifyPlaylist> PopulateSpotifyPlaylistAsync(SpotifyPlaylist playlist);
+        public Task<SpotifyPlaylist> PopulateSpotifyPlaylistAsync(SpotifyPlaylist playlist, FullPlaylist spotifyPlaylist = null);
-        public Task<SpotifyPlaylist> PopulateSpotifyAlbumAsync(SpotifyPlaylist playlist);
+        public Task<SpotifyPlaylist> PopulateSpotifyAlbumAsync(SpotifyPlaylist playlist, FullAlbum spotifyAlbum = null);
-        public Task<LavalinkTrack> PopulateTrackAsync(LavalinkTrack track);
+        public Task<LavalinkTrack> PopulateTrackAsync(LavalinkTrack track, FullTrack spotifyFullTrack = null);
 
     }
 
@@ -29,10 +30,13 @@ namespace TomatenMusic.Services
         public ILogger _logger { get; set; }
         public IAudioService _audioService { get; set; }
 
+        public ObjectCache Cache { get; set; }
+
         public SpotifyService(SpotifyClientConfig config, ILogger<SpotifyService> logger, IAudioService audioService) : base(config)
         {
             _logger = logger;
             _audioService = audioService;
+            Cache = MemoryCache.Default;
         }
 
         public async Task<MusicActionResponse> ConvertURL(string url)
@@ -43,9 +47,11 @@ namespace TomatenMusic.Services
                 .Replace("https://open.spotify.com/playlist/", "")
                 .Substring(0, 22);
 
+            _logger.LogDebug($"Starting spotify conversion for: {url}");
+
             if (url.StartsWith("https://open.spotify.com/track"))
             {
-                FullTrack sTrack = await Tracks.Get(trackId);
+                FullTrack sTrack = Cache.Contains(trackId) ? Cache.Get(trackId) as FullTrack : await Tracks.Get(trackId);
 
                 _logger.LogInformation($"Searching youtube from spotify with query: {sTrack.Name} {String.Join(" ", sTrack.Artists)}");
 
@@ -53,39 +59,43 @@ namespace TomatenMusic.Services
 
                 if (track == null) throw new ArgumentException("This Spotify Track was not found on Youtube");
 
-                return new MusicActionResponse(await FullTrackContext.PopulateAsync(track, trackId));
+                Cache.Add(trackId, sTrack, DateTimeOffset.MaxValue);
+
+                return new MusicActionResponse(await FullTrackContext.PopulateAsync(track, sTrack));
 
             }
             else if (url.StartsWith("https://open.spotify.com/album"))
             {
                 List<LavalinkTrack> tracks = new List<LavalinkTrack>();
 
-                FullAlbum album = await Albums.Get(trackId);
+                FullAlbum album = Cache.Contains(trackId) ? Cache.Get(trackId) as FullAlbum : await Albums.Get(trackId);
 
                 foreach (var sTrack in await PaginateAll(album.Tracks))
                 {
                     _logger.LogInformation($"Searching youtube from spotify with query: {sTrack.Name} {String.Join(" ", sTrack.Artists.ConvertAll(artist => artist.Name))}");
-
                     var track = await _audioService.GetTrackAsync($"{sTrack.Name} {String.Join(" ", sTrack.Artists.ConvertAll(artist => artist.Name))}", Lavalink4NET.Rest.SearchMode.YouTube);
 
                     if (track == null) throw new ArgumentException("This Spotify Track was not found on Youtube");
-
+                    
-                    tracks.Add(await FullTrackContext.PopulateAsync(track, sTrack.Uri));
+                    tracks.Add(await FullTrackContext.PopulateAsync(track, spotifyId: sTrack.Uri.Replace("spotify:track:", "")));
                 }
                 Uri uri;
                 Uri.TryCreate(url, UriKind.Absolute, out uri);
 
                 SpotifyPlaylist playlist = new SpotifyPlaylist(album.Name, album.Id, tracks, uri);
-                await PopulateSpotifyAlbumAsync(playlist);
+                await PopulateSpotifyAlbumAsync(playlist, album);
+
+                Cache.Add(trackId, album, DateTimeOffset.MaxValue);
 
                 return new MusicActionResponse(playlist: playlist);
 
             }
             else if (url.StartsWith("https://open.spotify.com/playlist"))
             {
+
                 List<LavalinkTrack> tracks = new List<LavalinkTrack>();
 
-                FullPlaylist spotifyPlaylist = await Playlists.Get(trackId);
+                FullPlaylist spotifyPlaylist = Cache.Contains(trackId) ? Cache.Get(trackId) as FullPlaylist : await Playlists.Get(trackId);
                 
                 foreach (var sTrack in await PaginateAll(spotifyPlaylist.Tracks))
                 {
@@ -98,56 +108,78 @@ namespace TomatenMusic.Services
 
                         if (track == null) throw new ArgumentException("This Spotify Track was not found on Youtube");
 
-                        tracks.Add(await FullTrackContext.PopulateAsync(track, fullTrack.Uri));
+                        tracks.Add(await FullTrackContext.PopulateAsync(track, fullTrack));
                     }
 
                 }
                 Uri uri;
                 Uri.TryCreate(url, UriKind.Absolute, out uri);
                 SpotifyPlaylist playlist = new SpotifyPlaylist(spotifyPlaylist.Name, spotifyPlaylist.Id, tracks, uri);
-                await PopulateSpotifyPlaylistAsync(playlist);
+                await PopulateSpotifyPlaylistAsync(playlist, spotifyPlaylist);
+
+                Cache.Add(trackId, spotifyPlaylist, DateTimeOffset.MaxValue);
 
                 return new MusicActionResponse(playlist: playlist);
             }
             return null;
         }
    
-        public async Task<SpotifyPlaylist> PopulateSpotifyPlaylistAsync(SpotifyPlaylist playlist)
+        public async Task<SpotifyPlaylist> PopulateSpotifyPlaylistAsync(SpotifyPlaylist playlist, FullPlaylist spotifyPlaylist = null)
         {
-            var list = await this.Playlists.Get(playlist.Identifier);
+            FullPlaylist list = spotifyPlaylist;
-            playlist.Description = list.Description;
+            if (list == null) 
-            playlist.AuthorUri = new Uri(list.Owner.Uri);
+                list = await this.Playlists.Get(playlist.Identifier);
+
+            string desc = list.Description;
+
+            playlist.Description = desc.Substring(0, Math.Min(desc.Length, 1024)) + (desc.Length > 1020 ? "..." : " ");
+            if (playlist.Description.Length < 2)
+                playlist.Description = "None";
+
+            playlist.AuthorUri = new Uri($"https://open.spotify.com/user/{list.Owner.Id}");
             playlist.AuthorName = list.Owner.DisplayName;
             playlist.Followers = list.Followers.Total;
-            playlist.Url = new Uri(list.Uri);
+            playlist.Url = new Uri($"https://open.spotify.com/playlist/{playlist.Identifier}");
-            playlist.AuthorThumbnail = new Uri(list.Owner.Images.First().Url);
+            try
+            {
+                playlist.AuthorThumbnail = new Uri(list.Owner.Images.First().Url);
+            }
+            catch (Exception ex) { }
+
             return playlist;
         }
 
-        public async Task<SpotifyPlaylist> PopulateSpotifyAlbumAsync(SpotifyPlaylist playlist)
+        public async Task<SpotifyPlaylist> PopulateSpotifyAlbumAsync(SpotifyPlaylist playlist, FullAlbum spotifyAlbum = null)
         {
-            var list = await this.Albums.Get(playlist.Identifier);
+            FullAlbum list = spotifyAlbum;
-            playlist.Description = list.Label;
+            if (list == null)
-            playlist.AuthorUri = new Uri(list.Artists.First().Uri);
+                list = await this.Albums.Get(playlist.Identifier);
+
+            string desc = list.Label;
+
+            playlist.Description = desc.Substring(0, Math.Min(desc.Length, 1024)) + (desc.Length > 1020 ? "..." : " ");
+            playlist.AuthorUri = new Uri($"https://open.spotify.com/user/{list.Artists.First().Uri}");
             playlist.AuthorName = list.Artists.First().Name;
             playlist.Followers = list.Popularity;
-            playlist.Url = new Uri(list.Uri);
+            playlist.Url = new Uri($"https://open.spotify.com/album/{playlist.Identifier}");
 
             return playlist;
         }
 
-        public async Task<LavalinkTrack> PopulateTrackAsync(LavalinkTrack track)
+        public async Task<LavalinkTrack> PopulateTrackAsync(LavalinkTrack track, FullTrack spotifyFullTrack)
         {
             FullTrackContext context = (FullTrackContext)track.Context;
             if (context.SpotifyIdentifier == null)
                 return track;
 
-            var spotifyTrack = await this.Tracks.Get(context.SpotifyIdentifier);
+            FullTrack spotifyTrack = spotifyFullTrack;
+            if (spotifyTrack == null)
+                spotifyTrack = await Tracks.Get(context.SpotifyIdentifier);
 
             context.SpotifyAlbum = spotifyTrack.Album;
             context.SpotifyArtists = spotifyTrack.Artists;
             context.SpotifyPopularity = spotifyTrack.Popularity;
-            context.SpotifyUri = new Uri(spotifyTrack.Uri);
+            context.SpotifyUri = new Uri($"https://open.spotify.com/track/{context.SpotifyIdentifier}");
             track.Context = context;
 
             return track;

TomatenMusicCore/Services/TrackProvider.cs

@@ -14,11 +14,13 @@ namespace TomatenMusic.Music
     {
         public ISpotifyService _spotifyService { get; set; }
         public IAudioService _audioService { get; set; }
+        public YoutubeService _youtubeService { get; set; }
 
-        public TrackProvider(ISpotifyService spotify, IAudioService audioService)
+        public TrackProvider(ISpotifyService spotify, IAudioService audioService, YoutubeService youtubeService)
         {
             _audioService = audioService;
             _spotifyService = spotify;
+            _youtubeService = youtubeService;
         }
 
         public async Task<MusicActionResponse> SearchAsync(string query, bool withSearchResults = false)
@@ -55,7 +57,7 @@ namespace TomatenMusic.Music
 
             if (loadResult.LoadType == TrackLoadType.PlaylistLoaded && !isSearch)
                 return new MusicActionResponse(
-                    playlist: new YoutubePlaylist(loadResult.PlaylistInfo.Name, await FullTrackContext.PopulateTracksAsync(loadResult.Tracks), uri));
+                    playlist: await _youtubeService.PopulatePlaylistAsync(new YoutubePlaylist(loadResult.PlaylistInfo.Name, await FullTrackContext.PopulateTracksAsync(loadResult.Tracks), uri)));
             else
                 return new MusicActionResponse(await FullTrackContext.PopulateAsync(loadResult.Tracks.First()));
 

TomatenMusicCore/Services/YoutubeService.cs

@@ -37,13 +37,20 @@ namespace TomatenMusic.Services
 
             if (channel.Statistics.SubscriberCount != null)
                 context.YoutubeAuthorSubs = (ulong) channel.Statistics.SubscriberCount;
-            context.YoutubeAuthorThumbnail = new Uri(channel.Snippet.Thumbnails.High.Url);
+            context.YoutubeAuthorThumbnail = new Uri(channel.Snippet.Thumbnails.Default__.Url);
             context.YoutubeAuthorUri = new Uri($"https://www.youtube.com/channel/{channel.Id}");
-            context.YoutubeDescription = video.Snippet.Description;
+            string desc = video.Snippet.Description;
+
+            context.YoutubeDescription = desc.Substring(0, Math.Min(desc.Length, 1024)) + (desc.Length > 1020 ? "..." : " ");
             if (video.Statistics.LikeCount != null)
                 context.YoutubeLikes = (ulong) video.Statistics.LikeCount;
             context.YoutubeTags = video.Snippet.Tags;
-            context.YoutubeThumbnail = new Uri(video.Snippet.Thumbnails.High.Url);
+
+            try
+            {
+                context.YoutubeThumbnail = new Uri(video.Snippet.Thumbnails.High.Url);
+            }catch (Exception ex) { }
+
             context.YoutubeUploadDate = (DateTime)video.Snippet.PublishedAt;
             context.YoutubeViews = (ulong)video.Statistics.ViewCount;
             context.YoutubeCommentCount = video.Statistics.CommentCount;
@@ -51,7 +58,7 @@ namespace TomatenMusic.Services
             return track;
         }
 
-        public async Task<List<LavalinkTrack>> PopulateMultiTrackListAsync(IEnumerable<LavalinkTrack> tracks)
+        public async Task<List<LavalinkTrack>> PopulateTrackListAsync(IEnumerable<LavalinkTrack> tracks)
         {
             List<LavalinkTrack> newTracks = new List<LavalinkTrack>();
             foreach (var track in tracks)
@@ -59,19 +66,26 @@ namespace TomatenMusic.Services
 
             return newTracks;
         }
-        public async Task<LavalinkPlaylist> PopulatePlaylistAsync(YoutubePlaylist playlist)
+        public async Task<ILavalinkPlaylist> PopulatePlaylistAsync(YoutubePlaylist playlist)
         {
             var list = await GetPlaylistAsync(playlist.Identifier);
             var channel = await GetChannelAsync(list.Snippet.ChannelId);
 
             string desc = list.Snippet.Description;
 
-            playlist.Description = desc.Substring(0, Math.Min(desc.Length, 4092)) + (desc.Length > 4092 ? "..." : " ");
+            playlist.Description = desc.Substring(0, Math.Min(desc.Length, 1024)) + (desc.Length > 1020 ? "..." : " ");
-            playlist.Thumbnail = new Uri(list.Snippet.Thumbnails.High.Url);
+            if (playlist.Description.Length < 2)
+                playlist.Description = "None";
+
+            try
+            {
+                playlist.Thumbnail = new Uri(list.Snippet.Thumbnails.Maxres.Url);
+            }catch (Exception ex) { }
+            playlist.AuthorName = channel.Snippet.Title;
             playlist.CreationTime = (DateTime)list.Snippet.PublishedAt;
             playlist.YoutubeItem = list;
-            playlist.AuthorThumbnail = new Uri(channel.Snippet.Thumbnails.High.Url);
+            playlist.AuthorThumbnail = new Uri(channel.Snippet.Thumbnails.Default__.Url);
-            playlist.AuthorUri = new Uri($"https://www.youtube.com/playlist?list={playlist.Identifier}");
+            playlist.AuthorUri = new Uri($"https://www.youtube.com/channels/{channel.Id}");
 
             return playlist;
         }

TomatenMusicCore/TomatenMusicBot.cs

@@ -4,7 +4,6 @@ using Microsoft.Extensions.Logging;
 using DSharpPlus;
 using DSharpPlus.EventArgs;
 using DSharpPlus.Entities;
-using DSharpPlus.Net;
 using System.Linq;
 using DSharpPlus.SlashCommands;
 using DSharpPlus.SlashCommands.EventArgs;
@@ -77,7 +76,6 @@ namespace TomatenMusic
 
                     })
 
-                    // Lavalink
                     .AddSingleton<IDiscordClientWrapper, DiscordShardedClientWrapper>()
                     .AddSingleton<IAudioService, LavalinkNode>()
                     .AddSingleton(new InactivityTrackingOptions
@@ -114,7 +112,6 @@ namespace TomatenMusic
         {
             await BuildServiceProvider();
 
-            //_ = _host.StartAsync();
 
             _host.Start();
             var client = ServiceProvider.GetRequiredService<DiscordShardedClient>();
@@ -189,7 +186,7 @@ namespace TomatenMusic
             if (e.Exception is NotFoundException)
                 logger.LogDebug($"{ ((NotFoundException)e.Exception).JsonMessage }");
             if (e.Exception is BadRequestException)
-                logger.LogDebug($"{ ((BadRequestException)e.Exception).JsonMessage }");
+                logger.LogInformation($"{ ((BadRequestException)e.Exception).Errors }");
             return Task.CompletedTask;
 
         }

TomatenMusicCore/Util/Common.cs

@@ -92,7 +92,7 @@ namespace TomatenMusic.Util
             return builder;
         }
 
-        public static DiscordEmbed AsEmbed(LavalinkPlaylist playlist)
+        public static DiscordEmbed AsEmbed(ILavalinkPlaylist playlist)
         {
 
             DiscordEmbedBuilder builder = new DiscordEmbedBuilder();
@@ -100,39 +100,43 @@ namespace TomatenMusic.Util
             if (playlist is YoutubePlaylist)
             {
                 YoutubePlaylist youtubePlaylist = (YoutubePlaylist)playlist;
-                builder
+                Console.WriteLine($"{playlist.AuthorName}, {playlist.AuthorUri.ToString()}, {playlist.AuthorThumbnail.ToString()}");
-                .WithAuthor(playlist.AuthorName, playlist.AuthorUri.ToString(), youtubePlaylist.AuthorThumbnail.ToString())
+                builder.WithAuthor(playlist.AuthorName, playlist.AuthorUri.ToString(), youtubePlaylist.AuthorThumbnail.ToString());
-                .WithTitle(playlist.Name)
+                builder.WithTitle(playlist.Name);
-                .WithUrl(playlist.Url)
+                builder.WithUrl(playlist.Url);
-                .WithDescription(playlist.Description)
+                builder.WithDescription(TrackListString(playlist.Tracks, 4000));
-                .WithImageUrl(youtubePlaylist.Thumbnail)
+                builder.WithImageUrl(youtubePlaylist.Thumbnail);
-                .AddField("Tracks", TrackListString(playlist.Tracks), false)
+                builder.AddField("Description", playlist.Description, false);
-                .AddField("Track Count", $"{playlist.Tracks.Count()} Tracks", true)
+                builder.AddField("Track Count", $"{playlist.Tracks.Count()} Tracks", true);
-                .AddField("Length", $"{Common.GetTimestamp(playlist.GetLength())}", true)
+                builder.AddField("Length", $"{Common.GetTimestamp(playlist.GetLength())}", true);
-                .AddField("Create Date", $"{youtubePlaylist.CreationTime:dd. MMMM, yyyy}", true);
+                builder.AddField("Create Date", $"{youtubePlaylist.CreationTime:dd. MMMM, yyyy}", true);
                 
             }else if (playlist is SpotifyPlaylist)
             {
                 SpotifyPlaylist spotifyPlaylist = (SpotifyPlaylist)playlist;
-                builder
+
-                .WithAuthor(playlist.AuthorName, playlist.AuthorUri.ToString(), spotifyPlaylist.AuthorThumbnail.ToString())
+                builder.WithTitle(playlist.Name);
-                .WithTitle(playlist.Name)
+                builder.WithUrl(playlist.Url);
-                .WithUrl(playlist.Url)
+                builder.WithDescription(TrackListString(playlist.Tracks, 4000));
-                .WithDescription(playlist.Description)
+                builder.AddField("Description", playlist.Description, false);
-                .AddField("Tracks", TrackListString(playlist.Tracks), false)
+                builder.AddField("Track Count", $"{playlist.Tracks.Count()} Tracks", true);
-                .AddField("Track Count", $"{playlist.Tracks.Count()} Tracks", true)
+                builder.AddField("Length", $"{Common.GetTimestamp(playlist.GetLength())}", true);
-                .AddField("Length", $"{Common.GetTimestamp(playlist.GetLength())}", true)
+                builder.AddField("Spotify Followers", $"{spotifyPlaylist.Followers:N0}", true);
-                .AddField("Spotify Followers", $"{spotifyPlaylist.Followers:N0}", true);
+                if (spotifyPlaylist.AuthorThumbnail != null)
+                {
+                    builder.WithAuthor(playlist.AuthorName, playlist.AuthorUri.ToString(), spotifyPlaylist.AuthorThumbnail.ToString());
+                }else
+                    builder.WithAuthor(playlist.AuthorName, playlist.AuthorUri.ToString());
             }
 
-            return builder;
+            return builder.Build();
         }
 
         public static DiscordEmbed GetQueueEmbed(GuildPlayer player)
         {
             DiscordEmbedBuilder builder = new DiscordEmbedBuilder();
 
-            builder.WithDescription(TrackListString(player.PlayerQueue.Queue));
+            builder.WithDescription(TrackListString(player.PlayerQueue.Queue, 4000));
             builder.WithTitle("Current Queue");
             builder.WithAuthor($"{player.PlayerQueue.Queue.Count} Songs");
 
@@ -146,27 +150,32 @@ namespace TomatenMusic.Util
             builder.AddField("Length", GetTimestamp(timeSpan), true);
             builder.AddField("Loop Type", player.PlayerQueue.LoopType.ToString(), true);
             builder.AddField("Autoplay", player.Autoplay ? "✅" : "❌", true);
-            if (player.PlayerQueue.PlayedTracks.Any())
-                builder.AddField("History", TrackListString(player.PlayerQueue.PlayedTracks), true);
             if (player.PlayerQueue.CurrentPlaylist != null)
                 builder.AddField("Current Playlist", $"[{player.PlayerQueue.CurrentPlaylist.Name}]({player.PlayerQueue.CurrentPlaylist.Url})", true);
 
+            if (player.PlayerQueue.PlayedTracks.Any())
+                builder.AddField("History", TrackListString(player.PlayerQueue.PlayedTracks, 1000), true);
+
             return builder;
         }
 
-        public static string TrackListString(IEnumerable<LavalinkTrack> tracks)
+        public static string TrackListString(IEnumerable<LavalinkTrack> tracks, int maxCharacters)
         {
             StringBuilder builder = new StringBuilder();
+            string lastString = " ";
             int count = 1;
             foreach (LavalinkTrack track in tracks)
             {
-                FullTrackContext context = (FullTrackContext)track.Context;
+                if (builder.ToString().Length > maxCharacters)
-                if (count > 15)
                 {
-                    builder.Append(String.Format("***And {0} more...***", tracks.Count() - 15));
+                    builder = new StringBuilder(lastString);
+                    builder.Append(String.Format("***And {0} more...***", tracks.Count() - count));
                     break;
                 }
 
+                FullTrackContext context = (FullTrackContext)track.Context;
+
+                lastString = builder.ToString();
                 builder.Append(count).Append(": ").Append($"[{track.Title}]({context.YoutubeUri})").Append(" [").Append(Common.GetTimestamp(track.Duration)).Append("] | ");
                 builder.Append($"[{track.Author}]({context.YoutubeAuthorUri})").Append("\n\n");
                 count++;