tueem/Marinara
1
1
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

fix(registry): fix logic error in InteractionEntry identifier checking and fix InteractionIdentifier#equals to actually recursively check parent identifiers
Some checks failed
github-mirror / push-github (push) Successful in 1m44s
Details
Build / Gradle-Build (push) Successful in 38s
Details
Test / Gradle-Test (push) Failing after 46s
Details

Browse Source
This commit is contained in:
tueem 2025-03-29 18:37:51 +01:00
parent 0973016a74
commit 8495659364
Signed by: tueem
GPG Key ID: 65C8667EC17A88FB
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/src/main/java/net/tomatentum/marinara/interaction/ident/InteractionIdentifier.java
View File

@ -80,7 +80,7 @@ public class InteractionIdentifier {
return false; return false;
if (!name().equals(ident.name())) if (!name().equals(ident.name()))
return false; return false;
return Objects.equals(ident, obj); return Objects.equals(parent(), ident.parent());
} }
@Override @Override

2
lib/src/main/java/net/tomatentum/marinara/registry/InteractionEntry.java
View File

@ -36,7 +36,7 @@ public class InteractionEntry {
public InteractionEntry addMethod(InteractionMethod method) { public InteractionEntry addMethod(InteractionMethod method) {
InteractionIdentifier identifier = method.identifier(); InteractionIdentifier identifier = method.identifier();
if (this.identifier().equals(identifier)) if (!this.identifier().equals(identifier))
throw new IllegalArgumentException("Method's identifier did not equal the entry's identifier"); throw new IllegalArgumentException("Method's identifier did not equal the entry's identifier");
this.methods.add(method); this.methods.add(method);